Ecai23 #264
Merged
Ecai23 #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a warning when doing 'poetry install': > Warning: poetry.lock is not consistent with pyproject.toml. You may be getting improper dependencies. Run `poetry lock [--no-update]` to fix it. We run 'poetry lock --no-update' using poetry at version 1.6.1.
from 'search(ff)' to 'search(ff())'. Proper escaping of parenthesis has been applied.
| @@ -63,7 +63,7 @@ def get_planner_cmd( | |||
| str(bind_path / domain.name), | |||
| str(bind_path / problem.name), | |||
| # we need escaping due to nuances in using planutils with docker | |||
| f'--search "astar\\({self._heuristic.value}\\)"', | |||
| f'--search "astar\\({self._heuristic.value}\\(\\)\\)"', | |||
There was a problem hiding this comment.
change due to recent version of downward (missing reference).
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
==========================================
+ Coverage 89.79% 90.95% +1.15%
==========================================
Files 12 22 +10
Lines 549 984 +435
==========================================
+ Hits 493 895 +402
- Misses 56 89 +33
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -0,0 +1,65 @@ | |||
| import pkg_resources | |||
There was a problem hiding this comment.
pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
tests/test_adl_compiler/test_compilation_remove_disjunctive_goal.py
Outdated
Show resolved
Hide resolved
marcofavorito
force-pushed
the
ecai23
branch
from
9088c6a
to
c071aba
Compare
…on _compile_instance Suggested by @francescofuggitti: #264 (comment)
Potentially breaking change if someone relied on public functions with 'before' in their name. However, for vast majority of library uses, this should not have happened.
…new_conditional_effects'
Inspired by @francescofuggitti's comment: #264 (comment)
Signed-off-by: Francesco Fuggitti <francesco.fuggitti@gmail.com>
Signed-off-by: Francesco Fuggitti <francesco.fuggitti@gmail.com>
Signed-off-by: Francesco Fuggitti <francesco.fuggitti@gmail.com>
Benchmarks are now stored in a new repository. The new repository is added as a submodule in tests/benchmarks. Minor changes were required on the test code side so to adapt it to the new benchmark folder structure.
the poetry lock has been produced with `poetry lock --no-update`
marcofavorito
approved these changes
Oct 1, 2023
francescofuggitti
approved these changes
Oct 2, 2023
marcofavorito
added a commit
that referenced
this pull request
Oct 2, 2023
Co-Authored-By: Francesco Fuggitti <francescofuggitti@gmail.com> - Pnf -> PPNF: #264 (comment) - introduced -> introduces: #264 (comment) - encodind -> encoding: #264 (comment)
marcofavorito
added a commit
that referenced
this pull request
Oct 2, 2023
…on _compile_instance Suggested by @francescofuggitti: #264 (comment)
marcofavorito
added a commit
that referenced
this pull request
Oct 2, 2023
Inspired by @francescofuggitti's comment: #264 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Integration of the ecai23 ADL encoding.
Types of changes