-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register a Ruby 3.4 parser #991
Conversation
Rakefile lacks the following change: diff --git a/Rakefile b/Rakefile
index 778e61db..1afcf209 100644
--- a/Rakefile
+++ b/Rakefile
@@ -38,6 +38,7 @@ GENERATED_FILES = %w(lib/parser/lexer-F0.rb
lib/parser/ruby31.rb
lib/parser/ruby32.rb
lib/parser/ruby33.rb
+ lib/parser/ruby34.rb
lib/parser/macruby.rb
lib/parser/rubymotion.rb) Ref: #904 |
3cbb34a
to
f821862
Compare
@koic good catch. I updated my PR. |
Overall, this looks good. One point I forgot to mention is that the commit message title needs |
To avoid failing when running as part of ruby-head test builds. I did the same as previous years, just initialized 3.4 as a copy of 3.3.
f821862
to
2db7ffa
Compare
Ah, thank you. I fixed that as well. |
Thanks. Honestly I was hoping for some hype around Prism to slowly deprecate Also, branching 3.4 now means that we'll need to backport all changes starting from Ruby 3.3.1 both to Do you need a release? |
I highly suspect 3.4 will be the last one, but yeah, right now lots of tooling hasn't moved (and will probably take a while because
It would be nice, but no rush. |
|
Much appreciated. |
Parser gem has been started development for Ruby 3.4 (edge Ruby). whitequark/parser#991 And this PR update to require Parser 3.3.0.4 or higher, which contains `Parser::Ruby34`. https://github.com/whitequark/parser/blob/master/CHANGELOG.md#not-released-2024-01-15
Parser gem has been started development for Ruby 3.4 (edge Ruby). whitequark/parser#991 And this PR update to require Parser 3.3.0.4 or higher, which contains `Parser::Ruby34`. https://github.com/whitequark/parser/blob/master/CHANGELOG.md#not-released-2024-01-15
To avoid failing when running as part of ruby-head test builds.
I did the same as previous years, just initialized 3.4 as a copy of 3.3.