Issue 469 - Fallback to overview.html when pages do not exist for compare option #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishijain
force-pushed
the
issue469
branch
2 times, most recently
from
05b560e to
c55ca22
Compare
etagwerker
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
@rishijain Looks good, thanks!
Could you please solve the conflict?
rishijain
force-pushed
the
issue469
branch
2 times, most recently
from
418c3dc to
cc7f5b4
Compare
|
@etagwerker resolved. |
| root_directory_path = File.expand_path(root_directory) | ||
| file_path = "#{root_directory_path}/#{file_name}" | ||
| file_path = "#{root_directory_path}/overview.html" unless File.exist?(file_path) | ||
| file_path(file_path) |
There was a problem hiding this comment.
This is weird. What about naming the local var index_path or just path to not confuse it with the method name file_path?
There was a problem hiding this comment.
@nunosilva800 oh yes my apologies. How did I not see how bad that naming was. I have used index_path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check list:
Description: This fixes issue #469 .