Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

options.filter can break resolution of remote documents #111

Closed
whitlockjc opened this issue Apr 23, 2017 · 1 comment
Closed

options.filter can break resolution of remote documents #111

whitlockjc opened this issue Apr 23, 2017 · 1 comment

Comments

@whitlockjc
Copy link
Owner

If you ever use options.filter to resolve only remote (relative and/or remote) references, when resolving remote documents their non-remote references are not resolved. This is not the way it should be as all remote references regardless of the filter used for the root document should be used.
@whitlockjc
Copy link
Owner Author

apigee-127/swagger-tools#494

whitlockjc added a commit that referenced this issue Apr 23, 2017
@whitlockjc
Fix options.filter handling for remote references
14d11a2 
`options.filter` should only apply to the root document and prior to
this commit, it was not.  This resulted in remote references being
partially resolved in some cases.

Fixes #111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whitlockjc