Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional password to hub #865

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ayyash1
Copy link

@ayyash1 ayyash1 commented Oct 16, 2024

This update introduces a password feature for hubs within the application. When a hub with a password is opened, a modal prompts the user to enter the password. If the entered password is incorrect, the input is cleared, and no interactions with the app are allowed until the correct password is provided.

To enhance security, passwords will be hashed before storage using bcrypt, making it more challenging for unauthorized users to access sensitive information. This implementation addresses user requests for increased privacy while acknowledging that the password is stored in an easily accessible format within the .vha2 files

Screenshot 2024-10-16 200244

This update introduces a password feature for hubs within the application. When a hub with a password is opened, a modal prompts the user to enter the password. If the entered password is incorrect, the input is cleared, and no interactions with the app are allowed until the correct password is provided.

To enhance security, passwords will be hashed before storage using bcrypt, making it more challenging for unauthorized users to access sensitive information. This implementation addresses user requests for increased privacy while acknowledging that the password is stored in an easily accessible format within the .vha2 files
@ayyash1
Copy link
Author

ayyash1 commented Oct 16, 2024

@whyboris Please review my changes on this issue.

@whyboris
Copy link
Owner

Thank you @ayyash1 for addressing #842

I will not be able to merge this in until I resume work on VHA, which will be some time this winter. I hope you don't mind the delay 🙇‍♂️

@whyboris whyboris changed the title Update final-object.interface.ts Add optional password to hub Oct 16, 2024
@ayyash1
Copy link
Author

ayyash1 commented Oct 17, 2024

Thank you @ayyash1 for addressing #842

I will not be able to merge this in until I resume work on VHA, which will be some time this winter. I hope you don't mind the delay 🙇‍♂️

Thank you for the update! I completely understand and appreciate you letting me know. No worries about the delay—take your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants