Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate init ResolverSpec registration warning in has_patterns #178

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

jamie256
Copy link
Collaborator

There are some improvements pending in whylogs to make managing the UDF registrations easier in the scenarios we need to change them. This change checks for the old structure of the resolver specs, and then removes the duplicate UDFs similarly to how the old registrations are removed from the multicolumn_udfs

  • Check for format, and then conditionally perform mitigation change to unregister old UDFs
  • Incidental fix to add the injections langkit_data folder to .gitignore so that testing doesn't show up as a change

Tested against the Intro to LangKit notebook example.

Copy link
Contributor

@FelipeAdachi FelipeAdachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamie256 jamie256 merged commit 68d25bb into main Oct 30, 2023
12 checks passed
@jamie256 jamie256 deleted the dev/jamie/multi_init_mitigation branch October 30, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants