Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return EOF and ErrUnexpectedEOF correctly #64

Merged
merged 16 commits into from
Mar 17, 2022
Merged

Return EOF and ErrUnexpectedEOF correctly #64

merged 16 commits into from
Mar 17, 2022

Commits on Mar 9, 2022

  1. Use readerWithEOFContext to handle EOF vs ErrUnexpectedEOF cases

    @MarcoPolo
    MarcoPolo committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    099ab3e View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2022

  1. fix: specialize discard for readerWithEOFContext

    @Stebalien
    Stebalien committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    6eb0095 View commit details
    Browse the repository at this point in the history

  2. Check hasReadOnce in readByte methods

    @MarcoPolo
    MarcoPolo committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    0326313 View commit details
    Browse the repository at this point in the history

  3. Avoid allocation in ScanForLinks

    @MarcoPolo
    MarcoPolo committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    eecee09 View commit details
    Browse the repository at this point in the history

  4. fix: export eof reader and fix compile 

    Also regenerate tests, that's how I found this.
    @Stebalien
    Stebalien committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    1fdee4f View commit details
    Browse the repository at this point in the history

  5. feat: avoid creating new ReaderWithEOFContexts where possible

    @Stebalien
    Stebalien committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    3dcc3ab View commit details
    Browse the repository at this point in the history

  6. Fix GetPeeker magic

    @MarcoPolo
    MarcoPolo committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    4343a5f View commit details
    Browse the repository at this point in the history

  7. Use defer and remove ReaderWithEOFContext

    @MarcoPolo
    MarcoPolo committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    22488b2 View commit details
    Browse the repository at this point in the history

  8. feat: simplify "read once" checks

    @Stebalien
    Stebalien committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    083da62 View commit details
    Browse the repository at this point in the history

  9. fix: check for unexpected EOF in deferred unmarshaling

    @Stebalien
    Stebalien committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    86717ea View commit details
    Browse the repository at this point in the history

  10. Add TestErrUnexpectedEOF

    @MarcoPolo
    MarcoPolo committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    e120cdc View commit details
    Browse the repository at this point in the history

  11. Use errors.Is to detect wrapped EOF errors

    @MarcoPolo
    MarcoPolo committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    ae38a94 View commit details
    Browse the repository at this point in the history

  12. Wrap error at end so we don't lose error context

    @MarcoPolo
    MarcoPolo committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    b23fed4 View commit details
    Browse the repository at this point in the history

  13. Remove expectation of ErrUnexpectedEOF we just want to make sure we d… 

    …on't get EOF
    @MarcoPolo
    MarcoPolo committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    19357f6 View commit details
    Browse the repository at this point in the history

  14. Revert "Wrap error at end so we don't lose error context" 

    This reverts commit b23fed4.
    @MarcoPolo
    MarcoPolo committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    0396fd1 View commit details
    Browse the repository at this point in the history

  15. Revert "Use errors.Is to detect wrapped EOF errors" 

    This reverts commit ae38a94.
    @MarcoPolo
    MarcoPolo committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    c353e0a View commit details
    Browse the repository at this point in the history