Fix gx-go rewrite behaviour when arguments are provided #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'gx-go rewrite' is now recursive when arguments are not specified, but when they are, it isn't. This can create a problem in dependency is not specified in package.json.
Before the errors where ignored.
kevina
changed the title
schomatis
requested changes
Oct 5, 2018
There was a problem hiding this comment.
This is by no means your responsibility but please add the PR description as part of the usage documentation of the gx-go rewrite command since I wasn't even aware of what was the use case for adding arguments to that command (and I'm pretty sure many more users aren't).
main.go
Outdated
| keepSet[arg] = struct{}{} | ||
| } | ||
| undo := c.Bool("undo") | ||
| for a, b := range mapping { |
There was a problem hiding this comment.
Please rename these variables to something more descriptive.
main.go
Outdated
| return fmt.Errorf("%s not found", arg) | ||
| keepSet[arg] = struct{}{} | ||
| } | ||
| undo := c.Bool("undo") |
There was a problem hiding this comment.
Let's move this up and have buildRewriteMapping and this added logic refer the local undo variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gx-go rewriteis now recursive, that is it doesn't require all the packages used as imports be listed inpackage.json. However,gx-go rewrite <arg> ...is not. This can create problems when trying rewrite a dep, used but not specified inpackage.json.This fixed it by first creating the rewrite map then filtering map based on the arguments if specified.
This also means that it will not return an error if a package specified on the command line was not used as an import. However, I actually see that as a plus.
I needed this when discovering some bugs when pushing through the go-cid changes. I wanted to selectively rewrite all involved dependencies, but didn't want to pull in git versions of everything. This initially failed because some of the
package.jsonfiles do not directly specify all imports used.This is a change in behavior, so if this will break things I can make it an option, but thought I didn't see a strong need to preserve the old behavior.
Also, the
--fixoption ignores both--dry-runand any arguments. This should eventually be fixed but for now I just detected it and returned an error.