Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few fixes #1

Merged
merged 10 commits into from Feb 16, 2016
Merged

A few fixes #1

merged 10 commits into from Feb 16, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jan 25, 2016

Remaining issues:

  • doesn't seem to like redirects
  • doesn't send a response if both backends fail

@ghost
Copy link
Author

ghost commented Jan 26, 2016

doesn't seem to like redirects

fixed in the latest commit

doesn't seem to like redirects

i'm not sure the canceling is completely good, and free of races. especially the select block makes me think the other backend might receive a response too just before being cancelled, and then overwrite the legitimate first response. but maybe that's okay, if both backends come up with a good response at the same time?

@whyrusleeping
Copy link
Owner

ooooh, in response to your second point. Thats a good point, and we can fix it by checking if our channel is closed after closing the other channel:

select {
case <-ourChannel:
default:
}

or something like that

@ghost
Copy link
Author

ghost commented Jan 26, 2016

After fixing the redirect, there was another mysterious 404 instead of redirect on /docs/install in combination with IpnsHostnameOption, which fixed itself by turning it off and on again.

@ghost
Copy link
Author

ghost commented Feb 11, 2016

RFM -- this is good to go and has been the status quo on ipfs.io for a while

@ghost
Copy link
Author

ghost commented Feb 11, 2016

@noffle let's rebase yours on top

@hackergrrl
Copy link

hackergrrl commented Feb 11, 2016 via email

Lars Gierth added 2 commits February 15, 2016 23:41
Previously, 4xx was considered an illegitimate response.
It is now okay, except for 408, which is the gateway's
response in case of context.DeadlineExceeded errors (for now).
@ghost
Copy link
Author

ghost commented Feb 16, 2016

RFM -- this is good to go and has been the status quo on ipfs.io for a while

Even more good to go now :)

@whyrusleeping
Copy link
Owner

Alright, i'll merge this one now. Thanks!

whyrusleeping added a commit that referenced this pull request Feb 16, 2016
@whyrusleeping whyrusleeping merged commit 7a86608 into whyrusleeping:master Feb 16, 2016
@whyrusleeping whyrusleeping mentioned this pull request Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants