-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few fixes #1
A few fixes #1
Conversation
This reverts commit ab8c342.
fixed in the latest commit
i'm not sure the canceling is completely good, and free of races. especially the select block makes me think the other backend might receive a response too just before being cancelled, and then overwrite the legitimate first response. but maybe that's okay, if both backends come up with a good response at the same time? |
ooooh, in response to your second point. Thats a good point, and we can fix it by checking if our channel is closed after closing the other channel:
or something like that |
After fixing the redirect, there was another mysterious 404 instead of redirect on |
RFM -- this is good to go and has been the status quo on ipfs.io for a while |
@noffle let's rebase yours on top |
Sure; I'll take on the merge pain :)
|
Previously, 4xx was considered an illegitimate response. It is now okay, except for 408, which is the gateway's response in case of context.DeadlineExceeded errors (for now).
Even more good to go now :) |
Alright, i'll merge this one now. Thanks! |
Remaining issues: