Anchors bugfix #94
Merged
Anchors bugfix #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests. Also add missing '%' to the end of POSTFIX_SCACHE_LOOKUPS.
- some didn't define the end of the line properly, like POSTFIX_SMTPD_LOSTCONN, POSTFIX_SMTPD_PIPELINING, POSTFIX_SMTP_LOSTCONN or POSTFIX_SMTP_TIMEOUT - some where only lucky to pass the test data because of the missing anchors, like POSTFIX_DISCARD or POSTFIX_PS_VIOLATIONS - remove () around single patterns in aggregated patterns list, which were added when moving anchors there but are not necessary - fix data in test/discard_0001.yaml, we're matching the message only
…tern.
Also use POSTFIX_VIRTUAL pattern in virtual_0001.yaml. Testing for untested
patterns using:
sed -n '/aggregate all patterns/,$s/ .*//p' postfix.grok | tail -n +2 | \
while read pattern; do
grep -q "pattern: $pattern$" test/*.yaml \
|| echo $pattern not found
done
|
I don't like that the anchoring is in the grok file, it makes the patterns less usable/flexible when logging is not easily separated from surrounding cruft like timestamps, or other logging. Putting the anchors in the logstash config file is fine with me, and we can fix the test suite to use anchors too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized it was not good to place the anchors in the config, because only in the patterns file would they get tested. And right away some tests failed, because they were only working without anchors -> I updated the patterns where necessary, and a single test as well which included the whole syslog line instead of just the message.