This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
add Simplified Chinese Localization #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
非常感谢您的提交，能否合并成一个commit呢？ |
|
3个改进点我分成 3 个 commit，方便后期有问题随时按需回退 你要 1 个 commit 的话，我晚点再搞，现在在外面 |
|
了解了，那就稍等review完这几个commit结束就合并您的提交。非常感谢！ |
|
感谢！我觉得是否应该拆分为三个pr进行提交？ 我仅启动了压缩提交，这种情况下会导致这个commit同时包含了您三个修改点？ 或者将此 commit message 设置为最主要的修改也可以 |
|
@wibus-wee 本地同步测试patch后工作正常，可以考虑合并。 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues
Additional context