Skip to content

Commit

Permalink
fix: broken pokemon link (#865)
Browse files Browse the repository at this point in the history
  • Loading branch information
mariobuikhuizen authored Nov 18, 2024
1 parent 1938706 commit eed952a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
from solara.alias import rv

github_url = solara.util.github_url(__file__)

json_url = "https://jherr-pokemon.s3.us-west-1.amazonaws.com/index.json"
pokemon_base_url = "https://raw.githubusercontent.com/jherr/pokemon/0722479d4153b1db0d0326956b08b37f44a95a5f"
json_url = f"{pokemon_base_url}/index.json"


@solara.component
Expand Down Expand Up @@ -40,7 +40,7 @@ def Page():
for pokemon in pokemons[:20]:
with solara.Div():
name = pokemon["name"]
url = "https://jherr-pokemon.s3.us-west-1.amazonaws.com/" + pokemon["image"]
url = f'{pokemon_base_url}/{pokemon["image"]}'
# TODO: how to do this with solara
rv.Img(src=url, contain=True, max_height="200px")
solara.Text(name)
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/hooks_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def FetchFile(url=url, expected_size=None):


def test_hook_use_json():
url = "https://jherr-pokemon.s3.us-west-1.amazonaws.com/index.json"
url = "https://raw.githubusercontent.com/jherr/pokemon/0722479d4153b1db0d0326956b08b37f44a95a5f/index.json"
pokemons = 799

result = None
Expand Down

0 comments on commit eed952a

Please sign in to comment.