feat: event support in component_vue for calling python callbacks. #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
Argument like 'event_foo' will be available as the function foo in the vue template.
maartenbreddels
force-pushed
the
10-03-feat_event_support_in_component_vue_for_calling_python_callbacks
branch
from
ece20df to
db44d3b
Compare
iisakkirotko
approved these changes
Oct 10, 2023
| @@ -12,20 +12,35 @@ | |||
| P = typing_extensions.ParamSpec("P") | |||
|
|
|||
|
|
|||
| def _widget_from_signature(name, base_class: Type[widgets.Widget], func: Callable[..., None]) -> Type[widgets.Widget]: | |||
| traits = {} | |||
| def _widget_from_signature(classname, base_class: Type[widgets.Widget], func: Callable[..., None], event_prefix: str) -> Type[widgets.Widget]: | |||
There was a problem hiding this comment.
Is the change from name to classname a part of adding event functionality, or for general refactoring purposes?
There was a problem hiding this comment.
It was an unrelated change actually. The name was overridden in the for loop, causing the class name to be useless when errors occurred. Should have been a separate commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argument like 'event_foo' will be available as the function foo
in the vue template.