fix: fix pywebview compatibility by using requirejs correctly #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://solara-stable-pr-709.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cq76hruehbks73e53f30. |
maartenbreddels
force-pushed
the
fix_pywebview_compatible
branch
6 times, most recently
from
a5bbdc8 to
07d0966
Compare
maartenbreddels
force-pushed
the
fix_pywebview_compatible
branch
3 times, most recently
from
2a6f1f9 to
bc588c5
Compare
It seems we cannot (what is now called loadApp) outside a requirejs call, with the jupyter-vue dependencies. Otherwise this results in pywebview seeing jupyter-vue as null. Not sure why this does not happen with other browsers.
maartenbreddels
force-pushed
the
fix_pywebview_compatible
branch
from
bc588c5 to
ca9435e
Compare
|
qt seems like a better, more support solution. The dependencies of pywebview do not seem to be maintained that well, and it does not seem stable in CI (also not on pywebview's CI) Instead, see #724 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems we cannot (what is now called loadApp) outside a requirejs call, with the jupyter-vue dependencies. Otherwise this results in pywebview seeing jupyter-vue as null. Not sure why this does not happen with other browsers.