Fix #1712 with explicit sass imports via use #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The migration of sass in commit 37059c4 introduced several occurences of the optional keyword. This caused the styles being uncompletly generated, because the class-names before the keyword did not get resolved properly and thus CSS not being generated. This was because I did not understood the problem enough. This commit introduces explicit commits to the partials files that define the class-names.
datengraben
force-pushed
the
datengraben/fix-optional-sass-keyword
branch
from
ea1a6cd to
fc69c53
Compare
|
@hansmorb danke für die Analyse im Vorfeld! Bitte gib mir Rückmeldung ob es passt? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1713 +/- ##
=========================================
Coverage 54.05% 54.05%
Complexity 2626 2626
=========================================
Files 98 98
Lines 11646 11646
=========================================
Hits 6295 6295
Misses 5351 5351 ☔ View full report in Codecov by Sentry. |
|
Das klappt! Vielen lieben Dank für den schnellen Fix! |
hansmorb
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1712
The migration of sass in commit 37059c4 (PR #1671) introduced several occurences of the optional keyword. This caused the styles being uncompletly generated, because the class-names before the keyword did not get resolved properly and thus CSS not being generated. This was because I did not understood the problem enough. This commit introduces explicit commits to the partials files that define the class-names.