Increase phpstan level 2 #1735
Open
Increase phpstan level 2 #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove unneccessary null/isset checks * catch rule object creation exceptions * checks for 'false' return of wp_json_encode * logs to error when WP_DEBUG * return '' // graceful return in admin settings page (as stated in docstring)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1735 +/- ##
=========================================
Coverage 54.09% 54.10%
Complexity 2628 2628
=========================================
Files 98 98
Lines 11655 11655
=========================================
+ Hits 6305 6306 +1
+ Misses 5350 5349 -1 ☔ View full report in Codecov by Sentry. |
* remove unneccessary null/isset checks * catch rule object creation exceptions * checks for 'false' return of wp_json_encode * logs to error when WP_DEBUG * return '' // graceful return in admin settings page (as stated in docstring)
…-level-2' into datengraben/phpstan-level-2
* move variable comment above variable * remove redundant variable comment
…erbatim, hence readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successor to #1707