Use FD_CLOEXEC fcntl for WEB-server socket #248
Conversation
free() is not safe in fork()ed child when using threads. Don't close WEB-server socket manually, use FD_CLOEXEC fcntl instead.
|
Looks like this patch breaks wdctl restart functionality: At any rate we should avoid using free() in child code when forking. Maybe don't set FD_CLOEXEC, but convert fd_list_t from linked list to static array? fd_list_t is very simple structure so it can be just array. The only user for it is WEB-server. |
|
Something like this. |
free() is not safe in fork()ed child when using threads. Convert fd_list_t linked list to plain array in order to avoid free() call.
|
Hi, devs. |
|
Ah, great, I merged with the obsolete commit message.. Just to make sure I got this correctly: we cannot use free() in threads so we use a statically allocated array of webserver fds. Since it's not a (dynamically allocated) linked list, we don't have to call free - correct? |
|
@oleg-umnik @KazukiShimada appreciate the contribution, by the way. |
|
@mhaas, yes, that's right. Thanks! |
free() is not safe in fork()ed child when using threads. Don't close
WEB-server socket manually, use FD_CLOEXEC fcntl instead.
See rationale here: http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_atfork.html