Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override custom proxy params #451

Merged

Conversation

LeoVS09
Copy link
Contributor

@LeoVS09 LeoVS09 commented May 30, 2023

The current version does not allow to use ERC1967Proxy directly from OpenZepplin for UUPS proxy. It breaks on updates during proxy admin check, as UUPS does not have regular proxy admin.

This change adds the ability to override checkABIConflict and checkProxyAdmin directly through proxy params.

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

🚮 Removed packages: @typescript-eslint/eslint-plugin@4.29.2, @typescript-eslint/parser@4.29.2, axios@0.21.1, eslint-config-prettier@8.3.0, prettier-plugin-solidity@1.0.0-beta.17, solhint-plugin-prettier@0.0.5, ts-node@10.2.1, zksync-web3@0.14.3

@wighawag wighawag merged commit b2f8d6d into wighawag:master Jun 24, 2023
@wighawag
Copy link
Owner

Thanks @LeoVS09
it is available in 0.11.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants