Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't detect own edits as edit conflict #353

Open
NovemLinguae opened this issue Apr 27, 2024 · 2 comments · Fixed by #355
Open

don't detect own edits as edit conflict #353

NovemLinguae opened this issue Apr 27, 2024 · 2 comments · Fixed by #355
Labels
C-bug Category: bug high-priority Requested by different people on different occasions

Comments

@NovemLinguae
Copy link
Member

NovemLinguae commented Apr 27, 2024 •
edited

Reported by DoubleGrazing at https://en.wikipedia.org/wiki/Wikipedia_talk:WikiProject_Articles_for_creation#Commenting_causes_%27edit_conflict%27

#352 had to be reverted and needs more work.
@NovemLinguae NovemLinguae added C-bug Category: bug high-priority Requested by different people on different occasions labels Apr 27, 2024
@NovemLinguae
Copy link
Member Author

Steps to reproduce the bug in the patch at #352

  • from an account that isn't logged in, make an edit to Draft:NovemTest
  • log in, install AFCH
  • submit as page creator

What happens?

  • Edit conflict warning

What should happen instead?

  • No edit conflict warning

NovemLinguae added a commit to NovemLinguae/afc-helper that referenced this issue May 3, 2024
@NovemLinguae
don't detect own edits as edit conflict
3838e2a 
fixes wikimedia-gadgets#353
@NovemLinguae NovemLinguae mentioned this issue May 3, 2024
Merged
NovemLinguae added a commit that referenced this issue May 4, 2024
@NovemLinguae
don't detect own edits as edit conflict (#355)
1bb0b91 
* don't detect own edits as edit conflict

fixes #353

* fix

* fix

* comments, variable names

* refactor
@NovemLinguae
Copy link
Member Author

Original reporter states this bug is still present. Confirm with testing, then fix.

@NovemLinguae NovemLinguae reopened this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: bug high-priority Requested by different people on different occasions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

don't detect own edits as edit conflict NovemLinguae/afc-helper
1 participant
@NovemLinguae