-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handleSubmit: add "unsubmitted" as an option #241
handleSubmit: add "unsubmitted" as an option #241
Conversation
I do not see this as an issue that needs fixing. |
Abandoning. Received pushback. |
Would have been nice to have this patch today when I found this draftified draft that had no tags. Would have saved me a couple minutes looking up the template. If folks change their mind about not liking this patch, let me know and I'll revive it. |
Reopening due to renewed interest at https://en.wikipedia.org/wiki/Wikipedia_talk:WikiProject_Articles_for_creation#Template%3AAfC_submission%2Fdraft. Will see how that discussion shakes out then make a decision about this PR. |
This ideally need to be changed to {{draft article}}, not {{afc submission}}. I also question if this should be under "Submit", maybe add a "tag as draft" to the RHS popout menu? |
The moveToDraft script that is used for draftifications uses {{AfC submission|t}}, so that seems a bit more standard. Example diff. Can you share your reasoning for preferring the {{Draft article}} tag? What's RHS? |
RHS = right hand side My preferred reason is the fact that AFC is not mandatory for drafts, and the user should be choosing to use AfC, not forced to use it. Yes it's the preferred route, but let them decide that. I do agree with PrimeFac this is scopecreep however. {{AFC submission|t}} is added by {{subst:AfC draft}} anyway, which should be easy enough to remember. Have you checked how easy this is going to be to rebase onto the main branch, or will this PR need to be restarted? |
I'm not too worried about the rebase. Will cross that bridge after the approach and consensus are decided. Since I'm in favor of {{AfC submission|t}} in the AFCH submit dialog, you're in favor of {{Draft article}} in some other location, and Primefac is against, we're headed towards no consensus and re-closing the patch. |
I'm not tech-savvy, but I'm curious why this patch isn’t being allowed? Can someone explain this in layman terms please. |
Has nothing to do with the tech, but rather some folks believe that {{draft article}} should be used because "AfC is not required" and putting {{AfC submissionn/draft}} is "unduly forcing people to use the process" or somesuch. |
People gave a lot of reasons for not liking this. It wasn't just the "I prefer the {{Draft article}} template" argument. Here's some of the other arguments:
I feel this patch would have been completely harmless and a small improvement, but consensus did not go in that direction. Ah well. On the bright side, after a year or so, I finally did memorize |
No idea, but I still don't get why people don't just add {{AfC submission/draft}} since that's what the |t calls. (as far as the t itself goes, d is for decline, a is for accept, f and r don't really make any sense so the only letter left is t? Maybe it's for "temp" or "to be submitted") |
Fixes #240
Adds an "Unsubmitted" option to the combo box in the Submit dialog. Generates the following Wikicode:
{{AFC submission|t|ns=118|ts=}}
.Primefac objects below, but in the bug report appears to change his mind. He brings up a good point that this should not generate a timestamp, so I have made sure my code does not generate a timestamp.
The use case is a page in the Draft namespace that does not have any AFC template at all. This lets you add the AFC submission template, but in an unsubmitted state, which is useful sometimes.