Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use WikiProject banner shell on draft talk pages #365

Merged
merged 18 commits into from
Aug 23, 2024
Merged

Use WikiProject banner shell on draft talk pages #365

merged 18 commits into from
Aug 23, 2024

Commits on Aug 21, 2024

  1. allow es6 in test files (since they use node)

    @NovemLinguae
    NovemLinguae committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    a84def5 View commit details
    Browse the repository at this point in the history

  2. make existing test strings multi-line, for readability

    @NovemLinguae
    NovemLinguae committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    bd50277 View commit details
    Browse the repository at this point in the history

  3. add banner shell if needed

    @NovemLinguae
    NovemLinguae committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    5f1f3e8 View commit details
    Browse the repository at this point in the history

  4. Use WikiProject banner shell on draft talk pages 

    - Fix wikimedia-gadgets#319 Implement WP:PIQA (put the article's class rating in the banner shell instead of in the wikiproject templates)
- Fix wikimedia-gadgets#73 Multiple WikiProject banners should be collapsed in {{WikiProject banner shell}}
- In unit tests, switch from single quotes to backticks, for increased multi-line readability.
    @NovemLinguae
    NovemLinguae committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    cb43f58 View commit details
    Browse the repository at this point in the history

  5. fix linter errors

    @NovemLinguae
    NovemLinguae committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    1759578 View commit details
    Browse the repository at this point in the history

  6. fix regex bug

    @NovemLinguae
    NovemLinguae committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    52b2f7f View commit details
    Browse the repository at this point in the history

  7. add a banner shell, even if there's only 1 wikiproject

    @NovemLinguae
    NovemLinguae committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    830472f View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. handle existing banner shell

    @NovemLinguae
    NovemLinguae committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9dd2b4c View commit details
    Browse the repository at this point in the history

  2. remove extra line breaks between banners

    @NovemLinguae
    NovemLinguae committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    7c581e6 View commit details
    Browse the repository at this point in the history

  3. add test case

    @NovemLinguae
    NovemLinguae committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    7f9f82b View commit details
    Browse the repository at this point in the history

  4. add template redirect I saw in the wild today

    @NovemLinguae
    NovemLinguae committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c22102f View commit details
    Browse the repository at this point in the history

  5. add test. mark it as skipped since it's failing

    @NovemLinguae
    NovemLinguae committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    b720518 View commit details
    Browse the repository at this point in the history

  6. tweak comments

    @NovemLinguae
    NovemLinguae committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    e5ed346 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. completely rewrite AFCH.addTalkPageBanners()

    @NovemLinguae
    NovemLinguae committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    5adb7a7 View commit details
    Browse the repository at this point in the history

  2. get rid of "X banners added" edit summary code. simplifies things

    @NovemLinguae
    NovemLinguae committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    0f274a0 View commit details
    Browse the repository at this point in the history

  3. remove 3 unused parameters from AFCH.addTalkPageBanners

    @NovemLinguae
    NovemLinguae committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3a60f43 View commit details
    Browse the repository at this point in the history

  4. fix linter errors

    @NovemLinguae
    NovemLinguae committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    96d1e0c View commit details
    Browse the repository at this point in the history

  5. simplify AFCH.addTalkPageBanners return values

    @NovemLinguae
    NovemLinguae committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3037291 View commit details
    Browse the repository at this point in the history