README: Show which rules have options, and which are fixable #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 607 607
=========================================
Hits 607 607 |
jdforrester
reviewed
Oct 22, 2021
| @@ -81,11 +81,14 @@ The following global settings can be used under the `no-jquery` property to conf | |||
|
|
|||
| ## 📖 Rules | |||
|
|
|||
| Where rules are included in the configs `recommended`, `slim`, `all` or `deprecated-X.X` it is indicated below. Where rules are included with options this is indicated with a `†`. | |||
| Rules with options are indicated with ⚙️. Rules which are fixable are indicated with 🔧. | |||
There was a problem hiding this comment.
Quote this with `s like we do on the next line for †.
There was a problem hiding this comment.
The dagger is escaped because it becomes part of the config label: slim† and the escaping allows us to show the multi-character label as one graphical item. The emoji don't need this, it would just add a pointless background: 🔧
There was a problem hiding this comment.
It also messes up the emoji rendering of the gear: ⚙️ vs ⚙️
There was a problem hiding this comment.
They all look terrible to me (possibly an artefact of me using GItHub dark mode?).
jdforrester
force-pushed
the
rule-list
branch
from
aacd3cf to
2e1efe1
Compare
jdforrester
previously approved these changes
Oct 22, 2021
jdforrester
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.