Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint config #1253

Closed
wants to merge 1 commit into from
Closed

Update eslint config #1253

wants to merge 1 commit into from

Conversation

edg2s
Copy link
Member

@edg2s edg2s commented Apr 3, 2020

No description provided.

@edg2s
Copy link
Member Author

edg2s commented Apr 3, 2020

Failures appear unrelated to the patch.

"eslint-config-wikimedia": "^0.13.1",
"eslint-plugin-jsdoc": "^15.8.0",
"eslint-plugin-json": "^1.4.0",
"eslint": "^6.8.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we can't do that yet. We still need to be able to run this on node6

@Pchelolo
Copy link
Contributor

Pchelolo commented Apr 3, 2020

We unfortunately can't do this yet, we still need to be able to run this on node 6. eslint is not a prod dependency, but we want to be able to run tests on node 6 as well.

@edg2s
Copy link
Member Author

edg2s commented Apr 24, 2020

We could disable linting tests on 6, they only need to be checked in one environment...

@wikimedia-helper-bot-for-github

👋 Hi @edg2s,

Thank you for contributing to Wikimedia! This Github repository is a read-only mirror.
The project uses Gerrit for code review.
Please submit your pull request to Gerrit, so your code changes can be reviewed.

If you are interested in sticking around within the Wikimedia community, please take a look at https://www.mediawiki.org/wiki/New_Developers
Thanks in advance!

@Pchelolo
Copy link
Contributor

Pchelolo commented Feb 7, 2022

Superseded by #1299

@Pchelolo Pchelolo closed this Feb 7, 2022
@edg2s edg2s deleted the eslint branch February 8, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants