-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The sorting feature is added to all the tables #60
base: master
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,11 +10,17 @@ | |
</title> | ||
{% block stylesheets %} | ||
<link rel="stylesheet" href="//tools-static.wmflabs.org/cdnjs/ajax/libs/twitter-bootstrap/3.3.6/css/bootstrap.min.css" /> | ||
<link rel="stylesheet" href="//tools-static.wmflabs.org/cdnjs/ajax/libs/twitter-bootstrap/3.3.6/css/bootstrap.min.css" /> | ||
|
||
{% endblock %} | ||
{% block scripts %} | ||
<script type="text/javascript" src="//tools-static.wmflabs.org/cdnjs/ajax/libs/jquery/1.12.0/jquery.min.js"></script> | ||
<script type="text/javascript" src="//tools-static.wmflabs.org/cdnjs/ajax/libs/twitter-bootstrap/3.3.6/js/bootstrap.min.js"></script> | ||
<script src="sortable.min.js"></script> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file doesn't exist. Did you forget to commit it? Or should this be referencing a file in cdnjs? |
||
|
||
{% endblock %} | ||
|
||
|
||
</head> | ||
<body> | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,7 +51,7 @@ | |
<div id="scores"> | ||
<h3>{{ msg('scores') }}</h3> | ||
{% if can_view_scores %} | ||
<table class="table"> | ||
<table class="table" class="sortable-theme-bootstrap" data-sortable> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's already a Also, this table is the only one with the theme applied; is that intentional? |
||
<caption>{{ msg('scores-legend', [score_calculation_interval~'']) }}</caption> | ||
<thead> | ||
<tr> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,7 +29,7 @@ | |
3) the total number of constructive <em>Contributions</em> of all sorts. | ||
</p> | ||
|
||
<table class="table" role="table"> | ||
<table class="table" role="table" data-sortable> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No need for two spaces here. |
||
<caption>Scoring system</caption> | ||
<tr><th>Action taken</th><th>Points</th><th>Validations</th><th>Contributions</th></tr> | ||
<tr><td>From any status to Proofread:</td><td> 3</td><td> 0</td><td> 1</td></tr> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line duplicates the one before it. Did you mean to link to a different stylesheet?