Added contestant order in WSContest contest page #73
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samwilson Please review this patch. |
|
Looks good! Can you update the title and description of the PR here, including the addition of the relevant Phab task? See Commit message guidelines for details (not that this is Gerrit, but we use much the same conventions here on Github). |
|
Yes forsure, updating it just give me a min. |
Avartii
changed the title
|
@samwilson I have done the needful please have a look. Btw sorry for the delay. |
|
Thanks! |
|
Thanks to you for the guidance! @samwilson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added contestant order in WSContest contest page
I have added contestant rank on the contest page of WSContest. It will be beneficial to the contestant as well as admins to be able to tell, for example: who are the top 10 contestant, how many total contestants are there, etc.
Feature: T331507 (https://phabricator.wikimedia.org/T331507)