[ELY-2517] Moved SSLContextBuilder and related files to new module w… #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsearls
force-pushed
the
ELY-2517-Move-SSLContextBuilder
branch
from
3fe034f
to
7fe3817
Compare
…ldfly-elytron-ssl-builder.
rsearls
force-pushed
the
ELY-2517-Move-SSLContextBuilder
branch
from
7fe3817
to
8d3e3ba
Compare
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ildfly-elytron-ssl-builder.
https://issues.redhat.com/browse/ELY-2517
code changes
quite a few package-private classes had to be moved from base/src into
builder/src in order resolve class dependencies and minimize code
changes to files in base/src
base/src ... SSLExplorer.java had to be changed from package-private
to public. This has little to no side affect because the methods
are already tagged private and public.
base/src ... ElytronMessages.java was split into 2 files. Msgs specific
to builder/src classes are in builder/src ... ElytronMessages.java
Msgs specific to base/src classes remain in base/src ... ElytronMessages.java
The msgs specific to builder/src were removed from base/src ... ElytronMessages.java
There is 1 msg referenced in both base and builder modules. This msg
resides in both ElytronMessages.java files.
changes were made to tests/base/src/test/java/org/wildfly/security to
reference the classes in ssl/builder.
module sasl/base was updated to reference the ssl/builder module
module auth/client was updated to reference the ssl/builder module