Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELY-2547] Add Elytron Tool option to overwrite CLI script #2194

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

lvydra
Copy link
Contributor

@lvydra lvydra commented Sep 18, 2024

@lvydra
Copy link
Contributor Author

lvydra commented Sep 18, 2024

@darranl Well, it seems that FileSystemEncryptRealmCommandTes.testOverwritingScriptFileTrue is intermittently failing. I will try to tweak it.

@darranl darranl added the +1 DAL label Sep 19, 2024
@fjuma
Copy link
Contributor

fjuma commented Sep 19, 2024

@lvydra Looks like this is still flaky on CI.

@fjuma fjuma added the hold label Sep 19, 2024
@lvydra
Copy link
Contributor Author

lvydra commented Sep 20, 2024

@fjuma @darranl Please rerun the tests to confirm if the changes are stable.

@darranl
Copy link
Contributor

darranl commented Sep 20, 2024

Last run was green, running again for stability.

@fjuma
Copy link
Contributor

fjuma commented Sep 20, 2024

Last run was green, running again.

@fjuma
Copy link
Contributor

fjuma commented Sep 20, 2024

@lvydra Just so we can reference this later on if needed, would you be able to add a quick comment about the intermittent failure and how it was fixed?

@lvydra
Copy link
Contributor Author

lvydra commented Sep 23, 2024

Sure @fjuma . In FileSystemEncryptRealmCommandTest I have been using File.lastModified() method to check if the file has been modified, but as I have found out later this method does not always return the latest value on Windows probably due to the file attributes caching.
So I switched to assertion based on file content.

@darranl darranl removed the hold label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants