Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EJBCLIENT-175] Add getUri() method to Affinity hierarchy #171

Merged
merged 1 commit into from
Nov 29, 2016

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented Nov 14, 2016

No description provided.

@wildfly-ci
Copy link

Build 204 outcome was FAILURE using a merge of d21432c
Summary: Tests failed: 2 (2 new), passed: 1 Build time: 00:00:20

Failed tests

org.jboss.ejb.client.ProxyEqualityTestCase.testClientProxyEquality: java.lang.ExceptionInInitializerError
    at org.jboss.ejb.client.Affinity.<clinit>(Affinity.java:48)
    at org.jboss.ejb.client.StatelessEJBLocator.<init>(StatelessEJBLocator.java:71)
    at org.jboss.ejb.client.ProxyEqualityTestCase.testClientProxyEquality(ProxyEqualityTestCase.java:34)
Caused by: java.lang.IllegalArgumentException: Expected scheme-specific part at index 6: local:
    at java.net.URI.create(URI.java:852)
    at org.jboss.ejb.client.Affinity$LocalAffinity.<clinit>(Affinity.java:131)
    ... 32 more
Caused by: java.net.URISyntaxException: Expected scheme-specific part at index 6: local:
    at java.net.URI$Parser.fail(URI.java:2848)
    at java.net.URI$Parser.failExpecting(URI.java:2854)
    at java.net.URI$Parser.parse(URI.java:3057)
    at java.net.URI.<init>(URI.java:588)
    at java.net.URI.create(URI.java:850)
    ... 33 more


org.jboss.ejb.client.serialization.ProxySerializationTestCase.testProxySerialization: java.lang.NoClassDefFoundError: Could not initialize class org.jboss.ejb.client.Affinity
    at org.jboss.ejb.client.StatelessEJBLocator.<init>(StatelessEJBLocator.java:71)
    at org.jboss.ejb.client.serialization.ProxySerializationTestCase.testProxySerialization(ProxySerializationTestCase.java:49)


@wildfly-ci
Copy link

Build 205 outcome was FAILURE using a merge of fb454a1
Summary: Tests failed: 2, passed: 1 Build time: 00:00:07

Failed tests

org.jboss.ejb.client.ProxyEqualityTestCase.testClientProxyEquality: java.lang.ExceptionInInitializerError
    at org.jboss.ejb.client.Affinity.<clinit>(Affinity.java:49)
    at org.jboss.ejb.client.StatelessEJBLocator.<init>(StatelessEJBLocator.java:71)
    at org.jboss.ejb.client.ProxyEqualityTestCase.testClientProxyEquality(ProxyEqualityTestCase.java:34)
Caused by: java.lang.IllegalStateException: java.net.URISyntaxException: Expected scheme-specific part at index 6: local:
    at org.jboss.ejb.client.Affinity$LocalAffinity.<clinit>(Affinity.java:138)
    ... 32 more
Caused by: java.net.URISyntaxException: Expected scheme-specific part at index 6: local:
    at java.net.URI$Parser.fail(URI.java:2848)
    at java.net.URI$Parser.failExpecting(URI.java:2854)
    at java.net.URI$Parser.parse(URI.java:3057)
    at java.net.URI.<init>(URI.java:820)
    at org.jboss.ejb.client.Affinity$LocalAffinity.<clinit>(Affinity.java:136)
    ... 32 more


org.jboss.ejb.client.serialization.ProxySerializationTestCase.testProxySerialization: java.lang.NoClassDefFoundError: Could not initialize class org.jboss.ejb.client.Affinity
    at org.jboss.ejb.client.StatelessEJBLocator.<init>(StatelessEJBLocator.java:71)
    at org.jboss.ejb.client.serialization.ProxySerializationTestCase.testProxySerialization(ProxySerializationTestCase.java:49)


@dmlloyd
Copy link
Member Author

dmlloyd commented Nov 14, 2016

Apparently I've gone 15 years without knowing that java.net.URI won't accept "xxx:" as a valid URI.


static {
try {
uri = new URI("local", "-", null);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super happy about this. But Java doesn't support conforming "empty" URIs with only a scheme part. Still thinking of a way to sling this weakness into an advantage, somehow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't like this; trying to think of a better way, but if anyone has a suggestion or idea please speak up.

@dmlloyd dmlloyd merged commit 9ce05e9 into wildfly:master Nov 29, 2016
@dmlloyd dmlloyd deleted the ejbclient-175 branch January 18, 2017 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants