Change to remote ejb server implementation #175
Conversation
| @@ -288,10 +290,10 @@ public void processInvocation(final EJBReceiverInvocationContext receiverContext | |||
| } | |||
|
|
|||
| // write sec context | |||
| marshaller.writeInt(peerIdentityId); | |||
| marshaller.writeShort(peerIdentityId); | |||
There was a problem hiding this comment.
These have to be 4 byte integers.
There was a problem hiding this comment.
Fixed on client and server side.
| @@ -539,7 +546,7 @@ public void writeResponse(final Object response) { | |||
| } | |||
| } | |||
|
|
|||
| public void writeException(final Exception response) { | |||
| public void writeThrowable(final Throwable response) { | |||
There was a problem hiding this comment.
We don't ever want to write Errors or anything like that; generally the EJB protocol and spec deal in Exceptions only. Was there some reason this had to be widened?
There was a problem hiding this comment.
Current org.jboss.as.ejb3.remote.protocol.versionone.SessionOpenRequestHandler catches Throwable during session id generation so I assumed that some Errors may be thrown during session id generation.
tadamski
force-pushed
the
remote_server
branch
from
ace60d8
to
d48591f
Compare
| @@ -308,14 +303,20 @@ void handleInvocationRequest(final int invId, final InputStream input) throws IO | |||
| int transactionId = unmarshaller.readUnsignedShort(); | |||
| identity = identityId == 0 ? connection.getLocalIdentity() : connection.getLocalIdentity(identityId); | |||
| transaction = null; // todo: look up transaction by transactionId | |||
| locator = unmarshaller.readObject(EJBLocator.class); | |||
There was a problem hiding this comment.
Moving these methods changes the protocol (see protocol.txt). I think the app/mod name should come first, as described in that doc. Did you encounter a reason to change it?
| receiverContext.resultReady(new EJBReceiverInvocationContext.ResultProducer.Failed(e)); | ||
| return; | ||
| } else { | ||
| //TODO Elytron |
There was a problem hiding this comment.
This should be functional in the latest Remoting/Elytron versions. Did you encounter a problem?
There was a problem hiding this comment.
Encountered NullPointerException - checking versions... The same problem with current HEADs of remoting and elytron.
| @@ -416,7 +416,7 @@ private void writeFailedResponse(final int invId, final Exception e) { | |||
| this.transaction = transaction; | |||
| } | |||
|
|
|||
| int getInvId() { | |||
| public int getInvId() { | |||
There was a problem hiding this comment.
This is used in Association class implementation to trace incomming invocations on the server side.
tadamski
force-pushed
the
remote_server
branch
from
d48591f
to
7f222f1
Compare
tadamski
force-pushed
the
remote_server
branch
from
7f222f1
to
64f9bdb
Compare
|
Failure happens because I have made the version of jboss-remoting 5.0.0.Beta13 - will retest after the release. |
|
I've released 5.0.0.Beta13 of Remoting. Once that's updated in the POM I will merge this. |
|
I have already made it 5.0.0.Beta13 in the PR. |
|
Retest this please |
|
I manually restarted the test, looks like CI has cached the non-existence of this release. I'll try it again. |
This commit is a part of integrating RemoteSever with ejb3 subsystem.