[EJBCLIENT-234] Provide JNDI environment property to assign cluster affinity. #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlloyd
reviewed
May 22, 2017
| @@ -64,6 +64,11 @@ private EJBClient() { | |||
| public static final String SOURCE_ADDRESS_KEY = "jboss.source-address"; | |||
|
|
|||
| /** | |||
| * A JNDI context key which, if defined, identifies that the proxy to be created should have affinity to the cluster. | |||
| */ | |||
| public static final String CLUSTER_AFFINITY = "cluster-affinity"; | |||
There was a problem hiding this comment.
I can merge this as an interim commit, but this property should be qualified with "jboss.", and...
dmlloyd
reviewed
May 22, 2017
| // check if strong affinity for this proxy has been set in the environment | ||
| URI clusterAffinity = getClusterAffinityURIFromEnvironment(); | ||
| if (clusterAffinity != null) { | ||
| affinity = Affinity.forUri(clusterAffinity); |
There was a problem hiding this comment.
...this should accept a cluster name, not a URI, and use the (public) ClusterAffinity(String) constructor.
|
I'll fix them now. |
rachmatowicz
force-pushed
the
EJBCLIENT-234
branch
from
e98f0ec
to
2ed7bcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a JNDI environment property to allow a user to specify that all proxies created from the InitialContext will have strong affinity to the cluster named in the property.
See https://issues.jboss.org/browse/EJBCLIENT-234 for more details.