[EJBCLIENT-325] Clean up crashed/shutdown singleton cluster nodes from DNR #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachmatowicz
force-pushed
the
EJBCLIENT-325
branch
from
abe02fa
to
3fee9b5
Compare
tadamski
reviewed
Mar 20, 2019
| // keep a record of this URI if it has an associated cluster (EJBCLIENT-325) | ||
| if (clusterEffective != null) { | ||
| urisByCluster.computeIfAbsent(clusterEffective, ignored -> Collections.newSetFromMap(new ConcurrentHashMap<>())).add(uri); | ||
| } |
There was a problem hiding this comment.
It seems to me that we are only creating the entry for the first node. What about a scenario that we are connecting to another node of a cluster but there is already an entry for that custer in urisByCluster map. Shouldn't we add the node there as well?
There was a problem hiding this comment.
This actually does allow multiple entries to be added. If i'm not mistaken, if we call computeIfAbsent and there is no Set value associated with the key, it will be created and returned; otherwise, the existing value will be returned. In either case, the new uri will be added to the Set returned as a value. I'm also seeing sets with multiple URI entries in my logs.
| * However, if we call it with a cluster name, indicating that we are connecting to a cluster, instead of looking up the AuthenticationContext | ||
| * for the cluster member destination, it instead uses the AuthenticationContext for the URI which first connected to the cluster. | ||
| * This is the cluster effective URI, in the sense thatit is an effective URI (i.e. resolved) for a cluster - the same credentials will be used | ||
| * no matter which cluster member we connect to. |
There was a problem hiding this comment.
Which word is the typo? the thatit ?
src/main/java/org/jboss/ejb/protocol/remote/RemotingEJBDiscoveryProvider.java
Show resolved
Hide resolved
rachmatowicz
force-pushed
the
EJBCLIENT-325
branch
from
3fee9b5
to
63e517f
Compare
rhusar
suggested changes
Mar 21, 2019
| if (Logs.INVOCATION.isDebugEnabled()) { | ||
| Logs.INVOCATION.debugf("Received CLUSTER_TOPOLOGY_NODE_REMOVAL(%x) message from %s for (cluster, node) = (%s, %s)", msg, remoteEndpoint, clusterName, nodeName); | ||
| Logs.INVOCATION.debugf("Received CLUSTER_TOPOLOGY_NODE_REMOVAL(%x) message fron node %s for (cluster, node) = (%s, %s)", msg, remoteEndpoint, clusterName, nodeName); |
rachmatowicz
force-pushed
the
EJBCLIENT-325
branch
5 times, most recently
from
9e2be3e
to
3714de4
Compare
tadamski
reviewed
Mar 25, 2019
src/test/resources/last-node-to-leave-jboss-ejb-client.properties
Outdated
Show resolved
Hide resolved
src/test/resources/last-node-to-leave-jboss-ejb-client.properties
Outdated
Show resolved
Hide resolved
src/main/java/org/jboss/ejb/protocol/remote/RemotingEJBDiscoveryProvider.java
Show resolved
Hide resolved
rachmatowicz
force-pushed
the
EJBCLIENT-325
branch
from
3714de4
to
5782e51
Compare
tadamski
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to remove stale Discovered Node Registry (DNR) entries corresponding to singleton cluster nodes which are no longer available, let alone connected. This can happen when the last node of a cluster leaves, or crashes. For example, if a client invokes on a cluster with one member node1 and that member crashes, then a new member node2 joins, the client will see membership as {node1, node2} which is incorrect. This is due to the fact that the client depends on externally generated information (i.e. topology updates) to keep the DNR up to date.
For details of the fix, see: https://issues.jboss.org/browse/EJBCLIENT-325