Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EJBCLIENT-335] EJB Client Exception missing host:port #391

Merged
merged 1 commit into from
May 21, 2019
Merged

[EJBCLIENT-335] EJB Client Exception missing host:port #391

merged 1 commit into from
May 21, 2019

Conversation

tmiyargi
Copy link
Contributor

@tmiyargi tmiyargi commented May 20, 2019 •
edited
Loading

chengfang
chengfang reviewed May 20, 2019
View reviewed changes
Copy link
Contributor

@chengfang chengfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calling RequestSendFailedException(String, boolean) instead of RequestSendFailedException(Throwable, boolean) would lose the cause throwable. I'd suggest using RequestSendFailedException(String, Throwable, boolean).

@chengfang chengfang merged commit b71d771 into wildfly:4.0 May 21, 2019
@tmiyargi
Copy link
Contributor Author

tmiyargi commented May 21, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengfang chengfang chengfang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmiyargi @chengfang