[EJBCLIENT-389] DiscoveryEJBClientInterceptor: prefer local node if a… #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengfang
reviewed
Nov 19, 2020
| location = Affinity.LOCAL.getUri(); | ||
| } else { | ||
| location = uris.get(nodeName); | ||
| } |
There was a problem hiding this comment.
Does it work when exclude-local-receiver is true (e.g., the user always want invocations to go over network)?
There was a problem hiding this comment.
no, it won't respect this setting - I'm working on alternative solution
There was a problem hiding this comment.
@chengfang I have created an alternative solution which prioritize local URIs; this solution would respect exclude-local-receiver settings (when it is set LocalEJBReceiver is not registered and only remote URI would be added)
tadamski
force-pushed
the
EJBCLIENT-389
branch
from
8bb4d1f
to
4daf57a
Compare
chengfang
reviewed
Nov 20, 2020
| // we want to prioritize using local invocation | ||
| if(!uris.containsKey(nodeName) || location.equals(LOCAL_NODE_NAME)) { | ||
| uris.put(nodeName, location); | ||
| } |
There was a problem hiding this comment.
location is URI, LOCAL_NODE_NAME is String, so this expression will always evaluate to false.
There was a problem hiding this comment.
this was a bug, fixed
tadamski
force-pushed
the
EJBCLIENT-389
branch
from
4daf57a
to
c2ca089
Compare
tadamski
force-pushed
the
EJBCLIENT-389
branch
from
c2ca089
to
2708717
Compare
chengfang
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chengfang could you please review