[WFLY-17740] Add missing @fallback test in Microprofile Fault Tolerance quickstart #656
Conversation
|
Please add the link to the issue tracker on the first line |
|
@emmartins can you review this, please? |
@emmartins That would be me (btw a good hint is available in Maven project model - https://github.com/wildfly/quickstart/blob/main/microprofile-fault-tolerance/pom.xml#L40-L44) |
|
@emmartins I can't assign myself as reviewer - can you please fix the project permissions settings? Thanks! |
...erance/src/main/java/org/wildfly/quickstarts/microprofile/faulttolerance/CoffeeResource.java
Outdated
Show resolved
Hide resolved
...ava/org/wildfly/quickstarts/microprofile/faulttolerance/MicroProfileFaultToleranceITest.java
Outdated
Show resolved
Hide resolved
...erance/src/main/java/org/wildfly/quickstarts/microprofile/faulttolerance/CoffeeResource.java
Outdated
Show resolved
Hide resolved
ChristinaDsl
force-pushed
the
WFLY-17740
branch
2 times, most recently
from
ae11320
to
3fc846a
Compare
|
@rhusar Thank you. All changes have been made. |
|
@rhusar Is there anything else that you need from my side? |
Nope - just competing priorities on my side to get to do a full review... |
ChristinaDsl
force-pushed
the
WFLY-17740
branch
from
3fc846a
to
fc8fc79
Compare
There was a problem hiding this comment.
@ChristinaDsl Please review the prior changes to the testing and note that we have removed ARQ and reworked to use a remote client istead.
| @ArquillianResource | ||
| private URL deploymentUrl; | ||
|
|
||
| @Inject | ||
| private CoffeeResource coffeeResource; | ||
|
|
||
| @Inject | ||
| CoffeeRepositoryService coffeeRepository; |
There was a problem hiding this comment.
Remove this as this won't work when testing against deployment running in e.g. OpenShift.
|
@rhusar thanks for your comments. I will manage the fixes. |
ChristinaDsl
force-pushed
the
WFLY-17740
branch
from
fc8fc79
to
f69123f
Compare
|
@ChristinaDsl please verify the new test, one run on CI did fail |
|
@emmartins Yet again - could you please verify the permissions for this repository? I can't even mark (my own) conversations as resolved... |
|
@rhusar if I find that option... yes sure!!!! |
I am going to guess that it's just the triage permission. |
|
@rhusar can you please recheck now? |
|
@emmartins Sure. |
ChristinaDsl
force-pushed
the
WFLY-17740
branch
from
f69123f
to
0f42089
Compare
There was a problem hiding this comment.
The tests continue to produce intermittent results, for instance:
Error: Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.893 s <<< FAILURE! -- in org.wildfly.quickstarts.microprofile.faulttolerance.CoffeeResourceIT
Error: org.wildfly.quickstarts.microprofile.faulttolerance.CoffeeResourceIT.testCoffeeRecommendations -- Time elapsed: 0.282 s <<< FAILURE!
java.lang.AssertionError: expected:<2> but was:<1>
|
Merging since testsuite seems stable now, if an intermitent pops up again will open an issue, thanks @ChristinaDsl |
|
Thanks @ChristinaDsl and @emmartins ! |
|
Thank you too @emmartins and @rhusar! |
https://issues.redhat.com/browse/WFLY-17740
In this issue were added two Test methods, both testing a method with @fallback annotation . The first one tests the successful execution of the method, which also has specific time frame (with the help of @timeout). The second one secures that every time the execution time of the method exceeds the time limit, the Fallback method executed successfully.