Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-19261] microprofile-lra Quickstarts should have a root webpage similar to helloworld #897

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sudeshnas93
Copy link
Contributor

Copy link

openshift-ci bot commented Apr 19, 2024

Hi @sudeshnas93. Thanks for your PR.

I'm waiting for a wildfly member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sudeshnas93 sudeshnas93 force-pushed the WFLY-19261 branch 5 times, most recently from 26e40e2 to 30f586f Compare May 14, 2024 06:40
@@ -25,6 +25,6 @@
import jakarta.ws.rs.ApplicationPath;
import jakarta.ws.rs.core.Application;

@ApplicationPath("/")
@ApplicationPath("/rest")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ needs to be reserved for the root web page as required. Changed to /rest because there can be path conflicts if we don't change the rest endpoints path to something else other than /

@emmartins emmartins requested a review from xstefank June 18, 2024 09:37
@emmartins
Copy link
Contributor

hi @xstefank , as the author/owner of this QS, are you ok with this, which includes functional changes (commands moved from / to /rest)?

Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issue on my side, feel free to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants