-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-19261] microprofile-lra Quickstarts should have a root webpage similar to helloworld #897
base: main
Are you sure you want to change the base?
Conversation
Hi @sudeshnas93. Thanks for your PR. I'm waiting for a wildfly member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
microprofile-lra/src/main/java/org/wildfly/quickstarts/microprofile/lra/applicationlra.java
Outdated
Show resolved
Hide resolved
microprofile-lra/src/main/java/org/wildfly/quickstarts/microprofile/lra/ApplicationLra.java
Outdated
Show resolved
Hide resolved
26e40e2
to
30f586f
Compare
@@ -25,6 +25,6 @@ | |||
import jakarta.ws.rs.ApplicationPath; | |||
import jakarta.ws.rs.core.Application; | |||
|
|||
@ApplicationPath("/") | |||
@ApplicationPath("/rest") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/
needs to be reserved for the root web page as required. Changed to /rest
because there can be path conflicts if we don't change the rest endpoints path to something else other than /
…similar to helloworld
hi @xstefank , as the author/owner of this QS, are you ok with this, which includes functional changes (commands moved from / to /rest)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issue on my side, feel free to merge.
Issue: https://issues.redhat.com/browse/WFLY-19261
Linked Issue: https://issues.redhat.com/browse/WFLY-19075