[WFCORE-7035]: YAML extension doesn't support ParallelBoot. #6225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsavoie
force-pushed
the
WFCORE-7035
branch
2 times, most recently
from
742b7a4 to
9fa29d9
Compare
|
Core -> Full Integration Build 14010 outcome was FAILURE using a merge of 9fa29d9 Failed tests |
|
Core -> WildFly Preview Integration Build 14083 outcome was FAILURE using a merge of 9fa29d9 Failed tests |
bstansberry
requested changes
Nov 15, 2024
controller/src/main/java/org/jboss/as/controller/AbstractOperationContext.java
Show resolved
Hide resolved
| @@ -1237,6 +1240,9 @@ public final void reloadRequired() { | |||
|
|
|||
| @Override | |||
| public final void restartRequired() { | |||
| if (isBooting()) { | |||
| return; | |||
There was a problem hiding this comment.
Same here about debug logging.
There was a problem hiding this comment.
Can you add the debug logging?
There was a problem hiding this comment.
This still doesn't have the debug logging.
...oller/src/main/java/org/jboss/as/controller/persistence/yaml/YamlConfigurationExtension.java
Show resolved
Hide resolved
...oller/src/main/java/org/jboss/as/controller/persistence/yaml/YamlConfigurationExtension.java
Outdated
Show resolved
Hide resolved
...oller/src/main/java/org/jboss/as/controller/persistence/yaml/YamlConfigurationExtension.java
Show resolved
Hide resolved
ehsavoie
force-pushed
the
WFCORE-7035
branch
2 times, most recently
from
292c5d2 to
d697170
Compare
…rtRequired on boot. * AbstractOperationContext is ignoring reloadRequired() and restartRequired() if isBooting() is returning true. Jira: https://issues.redhat.com/browse/WFCORE-7038 Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
|
Core -> Full Integration Build 14395 outcome was FAILURE using a merge of 635ff97 Failed tests |
|
Core -> Full Integration Build 14099 outcome was FAILURE using a merge of 635ff97 Failed tests |
ehsavoie
force-pushed
the
WFCORE-7035
branch
3 times, most recently
from
32f397c to
4f1149a
Compare
|
Core -> Full Integration Build 14100 outcome was FAILURE using a merge of 4f1149a Failed tests |
ehsavoie
force-pushed
the
WFCORE-7035
branch
from
4f1149a to
cbb23a5
Compare
|
@bstansberry I have simplified the code and added testing coverage |
bstansberry
requested changes
Dec 10, 2024
| @@ -1237,6 +1240,9 @@ public final void reloadRequired() { | |||
|
|
|||
| @Override | |||
| public final void restartRequired() { | |||
| if (isBooting()) { | |||
| return; | |||
There was a problem hiding this comment.
Can you add the debug logging?
controller/src/main/java/org/jboss/as/controller/ParsedBootOp.java
Outdated
Show resolved
Hide resolved
...oller/src/main/java/org/jboss/as/controller/persistence/yaml/YamlConfigurationExtension.java
Show resolved
Hide resolved
|
Core -> WildFly Preview Integration Build 14182 outcome was FAILURE using a merge of cbb23a5 Failed tests |
ehsavoie
force-pushed
the
WFCORE-7035
branch
from
cbb23a5 to
d156f8e
Compare
|
@bstansberry I've taken your point into account. I also changed the algorithm a bit (again) since the ParrallelBootOp might have been changed by the remove operation so we should only use the 'final' one to update the list of child operations. |
|
Core -> WildFly Preview Integration Build 14183 outcome was FAILURE using a merge of d156f8e |
|
Core -> Full Integration Build 14402 outcome was FAILURE using a merge of d156f8e |
|
Core -> Full Integration Build 14104 outcome was FAILURE using a merge of d156f8e |
ehsavoie
force-pushed
the
WFCORE-7035
branch
2 times, most recently
from
3521a7b to
0c361fd
Compare
|
Core -> Full Integration Build 14403 outcome was FAILURE using a merge of 0c361fd |
* Adding YAML subsystem operations to the ParallelOperationHandler. * Adding more tests to cover that use-case. Jira: https://issues.redhat.com/browse/WFCORE-7035 Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
ehsavoie
force-pushed
the
WFCORE-7035
branch
from
0c361fd to
2e11a98
Compare
|
Core -> Full Integration Build 14106 outcome was UNKNOWN using a merge of 2e11a98 |
|
Core -> WildFly Preview Integration Build 14185 outcome was UNKNOWN using a merge of 2e11a98 |
|
/retest please |
|
Core -> WildFly Preview Integration Build 14186 outcome was FAILURE using a merge of 2e11a98 |
|
Core -> Full Integration Build 14107 outcome was FAILURE using a merge of 2e11a98 |
|
Core -> WildFly Preview Integration Build 14187 outcome was FAILURE using a merge of 2e11a98 |
|
Core -> Full Integration Build 14108 outcome was FAILURE using a merge of 2e11a98 |
|
Core -> Full Integration Build 14405 outcome was FAILURE using a merge of 2e11a98 |
|
Core -> Full Integration Build 14404 outcome was FAILURE using a merge of 2e11a98 Failed tests |
bstansberry
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
@ehsavoie I left a comment about debug logging, but unless something goes wrong please handle this with a follow-up PR, as I'd prefer to get this merged as soon as CI finishes.
| @@ -1237,6 +1240,9 @@ public final void reloadRequired() { | |||
|
|
|||
| @Override | |||
| public final void restartRequired() { | |||
| if (isBooting()) { | |||
| return; | |||
There was a problem hiding this comment.
This still doesn't have the debug logging.
|
Thanks @ehsavoie |
|
@bstansberry I created https://issues.redhat.com/browse/WFCORE-7088 to track your comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding YAML subsystem operations to the ParallelOperationHandler.
Jira: https://issues.redhat.com/browse/WFCORE-7035