Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-7074] Use the ModuleIdentifier.fromString() where a slot may … #6260

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

jamezp
Copy link
Member

@jamezp jamezp commented Nov 26, 2024

…be used in a string module name.

https://issues.redhat.com/browse/WFCORE-7074

…be used in a string module name.

https://issues.redhat.com/browse/WFCORE-7074
Signed-off-by: James R. Perkins <jperkins@redhat.com>
@jamezp jamezp requested a review from bstansberry November 26, 2024 20:03
@bstansberry
Copy link
Contributor

Perhaps this should also fix ExternalModuleService.addExternalModule. I believe the usage via GlobalDirectoryDeploymentService could incorporate a user-defined module name with a slot. It would be an edge case but I think the module name is the value part of a PathElement key/value pair, and thus could have a value like "foo:slot" or "foo:main".

@bstansberry bstansberry merged commit 2bdbac3 into wildfly:main Nov 27, 2024
13 checks passed
@bstansberry
Copy link
Contributor

Thanks @jamezp. This passed CI so we can deal with ExternalModuleService.addExternalModule separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants