-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFCORE-7082] Provide utilities to produce canonical representations … #6270
Conversation
Core -> Full Integration Build 14385 outcome was FAILURE using a merge of 94ef052 Failed tests
|
int i; | ||
for(i = 0; i < moduleSpec.length(); i = moduleSpec.offsetByCodePoints(i, 1)) { | ||
c = moduleSpec.codePointAt(i); | ||
if (c == 92) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does 92 == \
?
Does 58 == :
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
Thanks @bstansberry @jamezp |
…of module names
https://issues.redhat.com/browse/WFCORE-7082
I'm not super thrilled with the class name, method names, or putting this in the controller module, so thoughts are welcome.
This shouldn't be in the server module 'deployment' packages as the use case goes beyond DUPs. And if it's not in that package I'd prefer not to add new classes to 'server' that extensions might use.