[WFCORE-7104] Use ModuleDependency.Builder instead of deprecated ModuleDependency ctor in Elytron

[ropalka]

https://issues.redhat.com/browse/WFCORE-7104

[bstansberry]

@ropalka Can you deal with this as well:

{code}
public class PermissionsParser {

public static List<PermissionFactory> parse(final XMLStreamReader reader, final ModuleLoader loader, final ModuleIdentifier identifier)

{code}

I mean add a new method that takes String and then @deprecate(forRemoval=true) the current one.

There is code in WF that calls this method so if we add an alternative we can migrate that code to the alternative and then delete the deprecated one. I don't see any need to keep the deprecated one longer than it takes to change the WF use; it's not API meant for use outside our security layer.

[bstansberry]

Oh; never mind. I misread the title of this JIRA and thought it was a "get rid of non-breaking use of ModuleIdentifier" PR! So the change I requested is off-topic for this PR.

[yersan]

Thanks @ropalka @bstansberry