Prefixing unicode byte order marks are stripped from included files #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tools (particularly those on Windows - in particular, Visual Studio defaults to this behaviour) have a habit of saving unicode byte order marks (BOMs) at the start of all UTF-8 files (despite these not being necessary). These should be trimmed before being included. See nodejs/node-v0.x-archive#1918 for details concerning this.
An example of the bug is below (note that \ufeff is an example of a unicode BOM)
file1.html:
\ufeff This is some text.
file2.html:
\ufeff Some text here
Results in file 1 reading:
This is some text.
 Some text here
This occurs because BOMs should not occur in the middle of files (only at their starts)