Electron 4 support?

[anhang]

Any chance we can get electron 4 (electron-v69) support?

[kolnogorov]

I agree, now it doesn't work with actual Electron/Node.js versions at all.
What should we do, downgrade Electron or there are any better ways to get it to work?
At least, it would be great if you'll provide proper instructions how to manually build iohook under Electron 4, because it throws a lot of errors for now.

Thank you!

[Djiit]

Hi there, I did try to make prebuilt binaries for electron 4 but I hit some bugs.
I'll try to find some time to re-test it.
However the build is the same as describe in the docs

[Djiit]

Nope, it's clearly out of my knowledge.
I Did some tests on travis : just adding the new target (electron 4.0.5, abi 69) got me an error :

[ 87%] Building CXX object CMakeFiles/iohook.dir/src/iohook.cc.o
In file included from /home/travis/build/wilix-team/iohook/src/iohook.h:3:0,
                 from /home/travis/build/wilix-team/iohook/src/iohook.cc:1:
/home/travis/build/wilix-team/iohook/node_modules/nan/nan.h:24:26: fatal error: node_version.h: No such file or directory
 #include <node_version.h>

Any C++ dev here ?

[Djiit]

@DCzajkowski can you help us here ? thanks !

[anoadragon453]

Well I've tried messing about with this for about 2 hours and haven't figured out a fix. I tried switching all the dependencies to nan v2.12.1 but that hasn't solved it (we've had nan troubles in the past, but seems to just be a red herring).

Search engines don't bring much luck.

Darn you node_version.h!

Edit: Eh, or maybe nan just isn't updated to support Electron v4.x.x yet?

[anoadragon453]

Some insight: electron/electron#17072 (comment)

[Djiit]

Good catch. The problem here is you will need a c++11 compiler to use cmakejs 4.x or 5.x (5.1 is the latest) but iohook still use a lot of c++99 code. Do you want to have a look? You can start by bumping cmakejs and look into the flags used in cmakelist.txt

…

-- Julien Le mer. 20 févr. 2019 à 19:14, Andrew Morgan <notifications@github.com> a écrit :

Some insight: electron/electron#17072 (comment) <electron/electron#17072 (comment)> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#144 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABHZtCTN6_KLDSivdRwIifaxh-9slm_xks5vPZCVgaJpZM4a4S4O> .

[anoadragon453]

Is c++11 not backwards compatible with c++99? I can start with what you've said. I really wanna get this working on Electron v4 for inclusion into https://github.com/vector-im/riot-web :D

[anoadragon453]

So bumping cmake-js to "^5.1.0" seems to make it all just work???

Edit: Seems so.

[Djiit]

This is not what I saw ahah. Can you make a PR with your code and see if the CI passes ?

…

-- Julien Le jeu. 21 févr. 2019 à 18:07, Andrew Morgan <notifications@github.com> a écrit :

So bumping cmake-js to "^5.1.0" seems to make it all just work??? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#144 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABHZtKUcZQ-jYGWxLj2bEF7nRFuqcIRFks5vPtI0gaJpZM4a4S4O> .

[anoadragon453]

#148

[DCzajkowski]

Hey @Djiit, sorry for being so late to the party. I would really like to help, but unfortunately I have no clue how. The only thing I can do is wish you good luck :)