Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is HUGE and accomplishes the following:
FaviconFinder
base class but also it's "finders"Downloading a Favicon now looks like:
Not one single FaviconURL is returned, but rather a whole array of ALL the favicons (for a specific source) that was found. This allows developers to inspect the favicon and to download them based on any particular properties they had.
Developers can now also view the "sizes" HTML/WebApplicationManifestFile property that websites state their icons have, in the
sizeTag
property.If a developer wants the smallest or largest icon, they can easily call the following:
I'm hoping this API change is embraced, and if you have any questions or suggestions, I'm all ears!