Add configuration to pass prefetched html #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great idea, thank you! I'll go over this later tonight. |
will-lumley
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This package looks great and fits my needs, however I am using this in parallel with code I wrote to fetch the title/description from the HTML and wanted to optimize network usage. This PR adds an optional configuration for passing
prefetchedHTML, a SwiftSoupDocumentthat has already been fetched. This removes 1-2 unnecessary network requests if you already have fetched a page.Ideally the fetched data in
HTMLFaviconFinderwould be reused inWebApplicationManifestFaviconFindereven whenprefetchedHTMLisn't specified to reduce 1 network call, but I couldn't find a simple way to add that.