Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SwiftLint #79

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Update SwiftLint #79

merged 2 commits into from
Jul 30, 2024

Conversation

knightbenax
Copy link
Contributor

No description provided.

@will-lumley
Copy link
Owner

Hey knightbenax,
Thanks for setting up this PR, this is great.
The failed unit tests seem to be unrelated to your changes, so I will be looking into them tonight.

@will-lumley
Copy link
Owner

Hey @knightbenax - I just realised that the package you're replacing the official SwiftLint repository by is from an unknown source of SimplyDanny. Can you explain why this is a better option?

@knightbenax
Copy link
Contributor Author

@will-lumley that's the source that is on the official SwiftLint repository - https://github.com/realm/SwiftLint

@will-lumley
Copy link
Owner

will-lumley commented Jul 30, 2024

Hi @knightbenax - apologies but I think I'm confused.
In your PR you have changed the repository from https://github.com/realm/SwiftLint to https://github.com/SimplyDanny/SwiftLintPlugins. This is not the offical SwiftLint repository.

Screenshot 2024-07-30 at 10 02 33 PM

@knightbenax
Copy link
Contributor Author

@will-lumley do check the ReadME from https://github.com/realm/SwiftLint it has changed the SPM url to https://github.com/SimplyDanny/SwiftLintPlugins now

@will-lumley
Copy link
Owner

@knightbenax Great catch, thanks for walking me through that. Approved.

@will-lumley will-lumley merged commit eeb99af into will-lumley:main Jul 30, 2024
3 checks passed
@knightbenax
Copy link
Contributor Author

@will-lumley anytime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants