Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibilities with some null values for PHP 8.1 #114

Merged
merged 1 commit into from
Jan 30, 2022
Merged

Fix incompatibilities with some null values for PHP 8.1 #114

merged 1 commit into from
Jan 30, 2022

Conversation

W0rma
Copy link
Contributor

@W0rma W0rma commented Oct 7, 2021

Fixes #115

@W0rma W0rma marked this pull request as ready for review October 7, 2021 15:29
@W0rma
Copy link
Contributor Author

W0rma commented Oct 7, 2021

Are there any plans to switch from travis to github actions for this repo?

Edit: This PR adds a config for github actions

@usox
Copy link

usox commented Jan 5, 2022

@willdurand sorry to disturb but are there any chances of getting this merged soon?

@mnapoli
Copy link

mnapoli commented Jan 16, 2022

This is indeed blocking PHP 8.1 support for me as well.

@ElisDN
Copy link

ElisDN commented Jan 28, 2022

@willdurand sorry to disturb but are there any chances of getting this merged soon?

@alexandrbarabolia
Copy link

@willdurand please accept pr

@willdurand
Copy link
Owner

ha, oops. Let me see. I am not too much into GitHub actions so I'll need to take a closer look at ths proposed changes (or see if I can use Circle instead).

IIUC the actual 8.1 incompatibilities are related to some functions not accepting non-string params anymore?

@ElisDN
Copy link

ElisDN commented Jan 30, 2022

IIUC the actual 8.1 incompatibilities are related to some functions not accepting non-string params anymore?

Yes, strcasecmp is not accepting null values now.

@usox
Copy link

usox commented Jan 30, 2022

ha, oops. Let me see. I am not too much into GitHub actions so I'll need to take a closer look at ths proposed changes (or see if I can use Circle instead).

If it helps: From my pov, the action is looking good so far.

IIUC the actual 8.1 incompatibilities are related to some functions not accepting non-string params anymore?

Exactly. maybe a string cast could also do the trick.

@willdurand
Copy link
Owner

alright, so I moved the second commit to its own PR (see: #116) given it isn't strictly related to PHP 8.1. I filed an issue for these incompatibilities here: #115.

@willdurand
Copy link
Owner

hey @W0rma, thanks for your patch. Could you please rebase your PR so that CI can run? I cherry-picked your second commit and landed it on the main branch already.

@willdurand
Copy link
Owner

Nevermind, I can do it myself. You waited long enough on me to review this PR so let me finish the work here.

@willdurand willdurand changed the title Fix compatibility with PHP 8.1 Fix incompatibilities with some null values for PHP 8.1 Jan 30, 2022
@willdurand willdurand merged commit 68e9ea0 into willdurand:master Jan 30, 2022
@willdurand
Copy link
Owner

https://github.com/willdurand/Negotiation/releases/tag/3.1.0 (please test it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation notices with PHP 8.1
6 participants