-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incompatibilities with some null values for PHP 8.1 #114
Conversation
Are there any plans to switch from travis to github actions for this repo? Edit: This PR adds a config for github actions |
@willdurand sorry to disturb but are there any chances of getting this merged soon? |
This is indeed blocking PHP 8.1 support for me as well. |
@willdurand sorry to disturb but are there any chances of getting this merged soon? |
@willdurand please accept pr |
ha, oops. Let me see. I am not too much into GitHub actions so I'll need to take a closer look at ths proposed changes (or see if I can use Circle instead). IIUC the actual 8.1 incompatibilities are related to some functions not accepting non-string params anymore? |
Yes, |
If it helps: From my pov, the action is looking good so far.
Exactly. maybe a string cast could also do the trick. |
hey @W0rma, thanks for your patch. Could you please rebase your PR so that CI can run? I cherry-picked your second commit and landed it on the main branch already. |
Nevermind, I can do it myself. You waited long enough on me to review this PR so let me finish the work here. |
https://github.com/willdurand/Negotiation/releases/tag/3.1.0 (please test it) |
Fixes #115