Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

fix for #174: create npmrc containing prefix to build package symlinks properly #175

Merged
merged 4 commits into from
Jul 13, 2017

Conversation

Ma27
Copy link
Collaborator

@Ma27 Ma27 commented Jul 12, 2017

see #174

@Ma27 Ma27 added the bug label Jul 12, 2017
@Ma27 Ma27 added this to the 2.0 milestone Jul 12, 2017
@willdurand willdurand requested a review from themouette July 12, 2017 22:44
@Ma27 Ma27 force-pushed the bugfix/GH-174/repair-broken-npm-package-paths branch from aa935d0 to 1a020b5 Compare July 12, 2017 22:47
@Ma27
Copy link
Collaborator Author

Ma27 commented Jul 12, 2017

please note that this is just a bugfix for 2.0. In future version we might add more configuration possibilities to npmrc.

@Ma27 Ma27 removed the request for review from themouette July 13, 2017 09:20
@Ma27
Copy link
Collaborator Author

Ma27 commented Jul 13, 2017

note: in future versions we might want to enhance this behavior to allow a developer to tweak the npmrc file using puppet.
ATM this is a hotfix for #174 at the first glance, so it will go into a 2.0.0-alpha3 straight...

@Ma27 Ma27 merged commit 2edfb6c into master Jul 13, 2017
@Ma27 Ma27 deleted the bugfix/GH-174/repair-broken-npm-package-paths branch July 13, 2017 09:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant