Fix 2x-nested translation of record list fields #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For bet365/soap#47 When using `soap:erlang2wsdl` on the referenced `.hrl`, a crash occurs as described in the above issue. This is because the nesting of the translated `hobbies` field is doubled up; the return value from `erlsom_type2xsd:translateType/2` has the `MinOccurs`/`MaxOccurs` wrapper applied twice for lists. Ignore the list element type's `MinOccurs`/`MaxOccurs` and use the 0 and unbounded values, for lists, respectively. This will produce the same result as shown on https://github.com/bet365/soap/blob/6848d29d9d123c37f22b309f19de848f6309b66a/doc/generating_a_wsdl.md?plain=1#L160. [Source .hrl](https://github.com/bet365/soap/blob/856b5c418d8d40a6b5bcbbe3fd390c6a0b8d4f18/test/soap_SUITE_data/store.hrl)
danielfinke
force-pushed
the
fix-doubled-nested-list-translation
branch
from
562f06d
to
e800216
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bet365/soap#47
When using
soap:erlang2wsdlon the referenced.hrl, a crash occurs as described in the above issue. This is because the nesting of the translatedhobbiesfield is doubled up; the return value fromerlsom_type2xsd:translateType/2has theMinOccurs/MaxOccurswrapper applied twice for lists.Ignore the list element type's
MinOccurs/MaxOccursand use the 0 and unbounded values, for lists, respectively. This will produce the same result as shown on https://github.com/bet365/soap/blob/6848d29d9d123c37f22b309f19de848f6309b66a/doc/generating_a_wsdl.md?plain=1#L160.Source .hrl