Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Added support for ebpf tcptop - Issue#6 #7

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

maitreya-source
Copy link
Contributor

  • Added a new task to read prometheus metrics of ebpf_exporter's tcptop metrics.
  • Added new flags to expose to enable ebpf task.
  • Added new output prometheus metric for decoded ebpf output.

Issue #6

@maitreya-source maitreya-source changed the title Added support for ebpf tcptop. Add: Added support for ebpf tcptop - Issue#6 Dec 7, 2021
Copy link
Contributor Author

@maitreya-source maitreya-source left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the the review William :)

collector/task/ebpf/tcptop.go Show resolved Hide resolved
Copy link
Owner

@williamchanrico williamchanrico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maitreya-source Thanks a lot for the PR 💯
Other than that last comment, the changes LGTM

I will merge it once you're ready 🚀

Btw, do you have a sample ebpf_exporter config that we can include in README.md later?

@maitreya-source
Copy link
Contributor Author

maitreya-source commented Dec 9, 2021

Ready to merge :)

For ebpf_exporter config, I have a yaml file ready to be put as reference:

  • Short-term: Maybe we make a folder for ebpf_exporter config and put the yaml file there.
  • Another option could be to raise a PR to ebpf_exporter for the yaml config and put reference link in the readme here.

Copy link
Owner

@williamchanrico williamchanrico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@williamchanrico williamchanrico merged commit 8835946 into williamchanrico:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants