Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

テストケースの修正 - Fix test cases #49

Merged
merged 4 commits into from
Jun 9, 2022

Conversation

nard-tech
Copy link
Contributor

以下の変更を行いました.

  • テストケースが不十分な箇所 (Gimei::Name.first, Gime::Name.last) にテストを追加
  • メッセージが間違っている箇所 (Gimei#last, Gimei.last, Gimei::Name#romaji) について修正
  • Gimei::Name#romaji についてはメソッド定義順にテストケースの位置を変更

@willnet willnet merged commit 3d097b5 into willnet:main Jun 9, 2022
@willnet
Copy link
Owner

willnet commented Jun 9, 2022

ありがとうございます!

@nard-tech nard-tech deleted the feature/fix-test-cases branch June 9, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants