Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transformers Map<K,V>.havingKeys() and Map<K,V>.havingValues() #557

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HaydenMeloche
Copy link
Contributor

This adds some transformers allowing you to utilize Collection asserts on parts of a map.

Example for keys:

assertThat(mapOf("key" to "value")).havingKeys().containsOnly("key")

Example for values:

assertThat(mapOf("key" to "value")).havingValues().containsOnly("value")

Given that there is already a Map<K,V>.isNotEmpty() I thought it made sense to have these transformers throw an error if their corresponding parts have no values.

fixes #527

@JakeWharton
Copy link
Contributor

I thought it made sense to have these transformers throw an error if their corresponding parts have no values.

Do any other "having"-style functions also perform an implicit assertion?

Really my only criticism of this approach is that there's something pure in the "having" suite of functions being purely transformational in contrast to actual validation functions. There's nothing strictly wrong with doing assertThat(map).havingKeys().isEmpty(), after all, even if it's a bit redundant.

@JakeWharton
Copy link
Contributor

I did find some examples, such as key on a map (which should become havingKey if #522 moves forward). So retaining the implicit assertion here seems fine 👍 .

@HaydenMeloche
Copy link
Contributor Author

@JakeWharton I admittedly was on the fence here (and I'm definitely open to removing the assertion). Map<K,V>.key() was ultimately the reason I decided to leave in the assertion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assert on map should have keys() and values() functions
2 participants